-
Notifications
You must be signed in to change notification settings - Fork 32
Implements Notary Proofs #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of an arbitrary timer
You never know when users spam a button across multiple tabs
hacky workaround a panic when thread count is too high due to lack of destructors
GODrums
approved these changes
Sep 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few optional minor improvements. Overall, super impressive technology though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mega-PR that provides E2E functionality for computing tlsn proofs. There will be a few follow ups for submitting proofs and auto-computing them in certain circumstances.
Overview:
NOTARY_PROVEmethod for external communicationservice worker<->offscreencommunicationFirefox is not supported: It appears to not be possible to set
Cross-Origin-Embedder-PolicyandCross-Origin-Opener-Policyheaders on the FF background page itself (dynamic MV3 header rewrite rules were a no-go as well). Given the small % that FF makes up on the site, we can likely shift them to the app to complete associated tasks.Note
Introduce TLSNotary-based proof generation via a new NOTARY_PROVE API using an offscreen document with web worker threads, plus required CSP, build, and dependency updates.
NOTARY_PROVErequest (src/lib/bridge/handlers/notary_prove.ts) with concurrency limiting (MaxConcurrency) and newRequestType.NOTARY_PROVE.src/lib/notary/types.ts,src/lib/notary/utils.ts).src/offscreen/client.ts), handlers map and TLSN prove handler (src/offscreen/handlers/{handlers.ts,notary_prove.ts,types.ts}).src/offscreen/{offscreen.html,offscreen.ts,utils.ts}), worker exposingtlsn-jsviacomlink(src/offscreen/worker.ts).src/environment*.ts).manifest.json: setminimum_chrome_version109, addoffscreenpermission, andcontent_security_policy.extension_pagesfor WASM.webpack.config.js: include offscreen entry, copy TLSN WASM/assets, ProvideBuffer, add COEP/COOP dev headers, dev host permissions; filteroffscreenpermission for Firefox.tsconfig.json: changemoduletoes2022.tlsn-js,comlink,buffer.wait(ms)utility (src/lib/utils/snips.ts).Written by Cursor Bugbot for commit 8771aff. This will update automatically on new commits. Configure here.